Paper/Archive/CVE-2024-1631

CVE-2024-1631

Internet Computer agent-js — agent-js: Insecure Key Generation in `Ed25519KeyIdentity.generate`

Description · from the CVE record

Impact: The library offers a function to generate an ed25519 key pair via Ed25519KeyIdentity.generate with an optional param to provide a 32 byte seed value, which will then be used as the secret key. When no seed value is provided, it is expected that the library generates the secret key using secure randomness. However, a recent change broke this guarantee and uses an insecure seed for key pair generation. Since the private key of this identity (535yc-uxytb-gfk7h-tny7p-vjkoe-i4krp-3qmcl-uqfgr-cpgej-yqtjq-rqe) is compromised, one could lose funds associated with the principal on ledgers or lose access to a canister where this principal is the controller.

Affected

ProductAffectedFixed inSource
agent-jsv0.20.0-beta.0 – < v1.0.1v1.0.1CNA
agent-jsv0.20.0-beta.0 – < v1.0.1v1.0.1CISA-ADP

Scores by source

Dfinity (CNA)9.1CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:N
CISA ADPSSVCExploitation: none · Automatable: yes · Technical impact: total

References

refgithub.com/dfinity/agent-js/pull/851refnpmjs.com/package/@dfinity/identity/v/1.0.1refgithub.com/dfinity/agent-jsrefagent-js.icp.xyz/identity/index.htmlrefgithub.com/dfinity/agent-js/security/advisories/GHSA-c9vv-fhgv-cjc3